Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Create a triangle header image widget #489

Closed

Conversation

manav2modi
Copy link
Contributor

@manav2modi manav2modi commented Oct 17, 2024

Description

Creating a triangle header image widget so that it can be reused in other places.
Example - Single images on the bottomsheet for the place description

Fixes #488

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@manav2modi manav2modi linked an issue Oct 17, 2024 that may be closed by this pull request
@mihail-varbanov mihail-varbanov deleted the 488-feature-create-a-triangle-header-image-widget-1 branch October 18, 2024 07:21
@mihail-varbanov
Copy link
Collaborator

@manav2modi,

  1. I guess you want this merged in support/v1.7, not in develop? That's why I closed your pull request and created & merged a new one pointing to the right target branch.

  2. Please pay attention to the commits that I added in your work branch. I am getting tired of rejecting your PRs for the same reasons so many times.

  3. Hint: when you add your commits in your work branch, if you add the number of the GIT issue inside the commit message text, GIT links this commit to the issue that it is related to and lists it in the issue activity page. For illustration, you could see how my commits are listed in [FEATURE] Create a triangle header image widget #488 page. This makes easier to observe what work had been done on given GIT issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create a triangle header image widget
2 participants