Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ID-106]Expose TPS API for adding images #107

Merged
merged 16 commits into from
Jul 2, 2024
Merged

[ID-106]Expose TPS API for adding images #107

merged 16 commits into from
Jul 2, 2024

Conversation

stefanvit
Copy link
Collaborator

Description

Expose TPS API for adding images

**Resolves #106

Review Time Estimate

  • Immediately
  • Within a week
  • When possible

Type of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@stefanvit stefanvit requested a review from petyos July 2, 2024 12:04
@stefanvit stefanvit requested a review from mdryankov as a code owner July 2, 2024 12:04
@stefanvit stefanvit linked an issue Jul 2, 2024 that may be closed by this pull request
[TASK] Expose TPS API for adding images #106
Closed
petyos
petyos reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@petyos petyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look the changes I applied. Thanks.

@petyos petyos merged commit e93f8b7 into develop Jul 2, 2024
2 checks passed
@petyos petyos deleted the 106-task-expose-tps-api-for-adding-images branch July 2, 2024 13:02
roberlander2 added a commit to rokmetro/content-building-block-fork that referenced this pull request Oct 31, 2024
@roberlander2 @stefanvit
@shurwit @petyos @bsdworkin
Update develop (#5)
c7a0377 
* [ID-81] org_id could be lost on update operation (rokwire#82)

* set the Changelog.md

* Refill app_id & org_id on replacing the object

* set app and org ID in the filter

* fix the Changelog.md

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* [ID-69]Set logger (rokwire#70)

* set Changelog.md

* set the logger

* fix loggerOpts

* set logger in auth

* set logger into the database

* fix logger service id

---------

Co-authored-by: Stefan Vitanov <[email protected]>
Co-authored-by: Stephen Hurwit <[email protected]>

* [ID-76]Fix docs (rokwire#77)

* set Changelog.md

* structure the docs

* set  Api's docs

* set Client applications APIs docs

* set the deprecated Admin API's

* docs in progress

* in progress

* in progress

* set the Admin APIs

* remove the old docs

* fix the description

* fix docs

---------

Co-authored-by: Stefan Vitanov <[email protected]>
Co-authored-by: Stephen Hurwit <[email protected]>

* [rokwire#84] Prepare for deployment in OpenShift (rokwire#85)

* upgrade dependencies, fix breaking changes for auth lib

* fix merge issues

* add app-env.json

* upgrade dependencies

* Release v1.2.4, upgrade dependencies, fix Dockerfile

* [ID-89] Add user audio record availabillity (rokwire#90)

* Update CHANGELOG.md

* API is in progress

* Add encoding

* API 2 is in progress

* Define interfaces

* Validate file size

* Parse and validate file

* Check file type

* APIs are in progress

* Upload API is in progress

* Upload audio

* Get value from env variable

* API tweaks

* Generate correct key

* Prepare adapter function

* Hook up API

* Fix lint issues

---------

Co-authored-by: Petyo Stoyanov <[email protected]>

* Prepare version v1.3.0

* [ID-91] Expose delete user audio record API (rokwire#92)

* Update CHANGELOG.md

* Describe API better

* API is in progress

* API is in progress

* API is in progress

* Support audio/m4a

* API is done

---------

Co-authored-by: Petyo Stoyanov <[email protected]>

* Prepare version v1.4.0

* Hot fix - support video/mp4

* [rokwire#87] refactor support file types (rokwire#88)

* new apis to support file and data content items

* small fixes

* fixed secrets

* transaction context changes and changes from demo

* added in service impl

* fix lint issue

* upgrade to go1.21, upgrade dependencies

* remove unnecessary file, revert main.go testing change

* cleanup and permission check additions

* fix some docs typos, some small simplifications

* fixes to docs and indicies for DB

* fix some logging bugs

* update secrets baseline

* add permissions, cleanup naming, improve permission check

* use query params

* fix permission check issues, fix delete file

* optimize permission check

* update secrets baseline

---------

Co-authored-by: Ryan Oberlander <[email protected]>
Co-authored-by: shurwit <[email protected]>

* Release v1.5.0

* fix doc base url

* remove unused host env var

* Release v1.5.1

* fix dockerfile

* [rokwire#94] Use redirect to S3 for file downloads (EDIT: Stream files from S3) (rokwire#95)

* update get file content item API handlers to use redirect instead of direct file download

* update changelog

* change GetFileContentItem to use download stream instead of redirect

* remove superfluous WriteHeader calls

* update changelog

* Release v1.5.2

* [ID-97]Create "upload image" bbs API (rokwire#98)

* add the Changelog.md

* set the docs

* in progress

* set the bbs apis handler

* fix lint issue

* resolve comments

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* update version to 1.6.0

* [ID-100] Fix upload image BBs API (rokwire#101)

* Update CHANGELOG.md

* Fix empty spaces

* Update dockerfile

---------

Co-authored-by: Petyo Stoyanov <[email protected]>

* Prepare v1.6.1

* Hot fix

* [ID-104] Remove user data (rokwire#105)

* Update CHANGELOG.md

* Add model

* Add data logic struct

* Add core adapter

* in progress

* in progress

* Keep them grouped

* Move the interface on the right place

* Revert main.go as there was a lot of commented code.

* Core driver stuff

* Fix build

* Delete todo categories - in progress

* Delete profile image

* Use create function

* Delete voice record

* Fix timer

---------

Co-authored-by: Stefan Vitanov <[email protected]>

* Prepare v1.7.0

* [ID-106]Expose TPS API for adding images (rokwire#107)

* in progress

* add the Changelog.md

* in progress

* in progress

* fix

* fix lint issue

* TPS is third party, not first party

* Update comment

* Add the tps permission policy file file in dockerfile

* Please maintan the same allignment..

* Do not add the old doc annotations

* More generic name

* Fix path

* Fix the doc description

* Fix creating tps handler

* Remove wrong comment

---------

Co-authored-by: Stefan Vitanov <[email protected]>
Co-authored-by: Petyo Stoyanov <[email protected]>

* update the version to 1.8.0

---------

Co-authored-by: stefanvitanov <[email protected]>
Co-authored-by: Stefan Vitanov <[email protected]>
Co-authored-by: Stephen Hurwit <[email protected]>
Co-authored-by: Stephen Hurwit <[email protected]>
Co-authored-by: Petyo Stoyanov <[email protected]>
Co-authored-by: Petyo Stoyanov <[email protected]>
Co-authored-by: Ben Dworkin <[email protected]>
Co-authored-by: shurwit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petyos petyos petyos left review comments

@mdryankov mdryankov Awaiting requested review from mdryankov mdryankov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TASK] Expose TPS API for adding images
2 participants
@stefanvit @petyos