Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge develop into main #108

Merged
merged 1 commit into from
Jul 2, 2024
Merged

merge develop into main #108

merged 1 commit into from
Jul 2, 2024

Conversation

stefanvit
Copy link
Collaborator

  • in progress

  • add the Changelog.md

  • in progress

  • in progress

  • fix

  • fix lint issue

  • TPS is third party, not first party

  • Update comment

  • Add the tps permission policy file file in dockerfile

  • Please maintan the same allignment..

  • Do not add the old doc annotations

  • More generic name

  • Fix path

  • Fix the doc description

  • Fix creating tps handler

  • Remove wrong comment


Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Resolves #(add issue number here and remove parentheses)

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

* in progress

* add the Changelog.md

* in progress

* in progress

* fix

* fix lint issue

* TPS is third party, not first party

* Update comment

* Add the tps permission policy file file in dockerfile

* Please maintan the same allignment..

* Do not add the old doc annotations

* More generic name

* Fix path

* Fix the doc description

* Fix creating tps handler

* Remove wrong comment

---------

Co-authored-by: Stefan Vitanov <[email protected]>
Co-authored-by: Petyo Stoyanov <[email protected]>
@stefanvit stefanvit requested a review from mdryankov as a code owner July 2, 2024 17:11
@stefanvit stefanvit merged commit dcd6a96 into main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant