Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#209] Improve managed group admin assignment and synchronization #215

Merged
merged 10 commits into from
Aug 5, 2022

Conversation

shurwit
Copy link
Collaborator

@shurwit shurwit commented Aug 3, 2022

Description

Please provide a summary of the pull request and the issue it resolves. Please add necessary details, context, dependencies, explanation of when review is needed (see next section), etc.

Resolves #209

Review Time Estimate

Please give your idea of how soon this pull request needs to be reviewed by selecting one of the options below. This can be based on the criticality of the issue at hand and/or other relevant factors.

  • Immediately
  • Within a week
  • When possible

Type of changes

Please select a relevant option:

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Other (any another change that does not fall in one of the above categories.)

Checklist:

Please select all applicable options:

  • I have signed the Rokwire Contributor License Agreement (CLA). (Any contributor who is not an employee of the University of Illinois whose official duties include contributing to the Rokwire software, or who is not paid by the Rokwire project, needs to sign the CLA before their contribution can be accepted.)
  • I have updated the CHANGELOG.
  • I have read the Contributor Guidelines.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My change requires updating the documentation.
  • I have made necessary changes to the documentation.
  • I have added tests related to my changes.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@shurwit shurwit requested a review from mdryankov as a code owner August 3, 2022 22:30
@shurwit shurwit linked an issue Aug 3, 2022 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@mdryankov mdryankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 3 comments that need to be discussed further. Everything else looks good.

@shurwit
Copy link
Collaborator Author

shurwit commented Aug 4, 2022

Hi @mdryankov, thank you very much for the review and feedback! Let me know if you have any more questions or concerns.

@mdryankov mdryankov merged commit 1fced85 into develop Aug 5, 2022
@mdryankov mdryankov deleted the 209-improve-managed-group-admin branch August 5, 2022 06:41
@shurwit shurwit restored the 209-improve-managed-group-admin branch August 8, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve managed group admin assignment and synchronization
2 participants