Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][SDK-98] Crash creating folder #318

Merged
merged 2 commits into from
Sep 4, 2024
Merged

[FIX][SDK-98] Crash creating folder #318

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fafa23c
fix: log the error instead of throwing an exception
christianbuon Aug 16, 2024
269d4f6
docs: add comment
christianbuon Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions rollbar-java/src/main/java/com/rollbar/notifier/sender/queue/DiskQueue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,18 @@ private DiskQueue(Builder builder) {
this.maxSize = builder.maxSize;
this.queueFolder = builder.queueFolder;

/*
A RuntimeException can cause a silent crash, since the error would not be saved and in the next
session there would be no payload to send. So we just log the error.
*/
if (!this.queueFolder.exists()) {
if (!this.queueFolder.mkdirs()) {
throw new RuntimeException("Could not create folder: " + queueFolder);
csaba-ilonka-rollbar marked this conversation as resolved.
Show resolved Hide resolved
LOGGER.error("Could not create folder: {}", queueFolder);
}
}

if (!this.queueFolder.canRead() || !this.queueFolder.canWrite()) {
throw new RuntimeException("Not enough permissions folder: " + queueFolder);
LOGGER.error("Not enough permissions folder: {}", queueFolder);
}
}

Expand Down
Loading