Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prettify library and examples and enable format check in ci #111

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Prettify library and examples and enable format check in ci #111

merged 1 commit into from
Feb 27, 2024

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 24, 2024

Description of the change

This PR enables formatting checks in the CI with prettier and formats the entire project, including library, examples, config files and markdown.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 24, 2024
@matux matux force-pushed the matux/eslint-prettier-config branch 2 times, most recently from 139471c to 53c061c Compare February 26, 2024 16:45
Base automatically changed from matux/eslint-prettier-config to main February 26, 2024 18:52
@matux matux marked this pull request as ready for review February 26, 2024 18:59
@matux matux force-pushed the matux/format branch 3 times, most recently from 52ecd86 to 3e283a8 Compare February 26, 2024 22:40
mudetroit
mudetroit approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mudetroit mudetroit merged commit d8d3be8 into main Feb 27, 2024
5 checks passed
@matux matux deleted the matux/format branch February 27, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mudetroit mudetroit mudetroit approved these changes

@waltjones waltjones Awaiting requested review from waltjones

Assignees

@matux matux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matux @mudetroit