Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples for React 16 and Next.js 10 #114

Closed
wants to merge 2 commits into from
Closed

Conversation

matux
Copy link
Collaborator

@matux matux commented Feb 26, 2024

Description of the change

This PR adds two examples using the minimum supported versions of React and Next.js by our library. This is mainly there to ensure we don't lose compatibility with the upcoming changes.

Each example, like the others, go thru an npm ci, build and lint.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@matux matux self-assigned this Feb 26, 2024
@matux matux changed the base branch from main to matux/eslint February 26, 2024 12:35
@matux matux force-pushed the matux/eslint branch 6 times, most recently from 01e52bf to c1db84a Compare February 28, 2024 19:48
Base automatically changed from matux/eslint to main February 28, 2024 20:42
@matux matux closed this Mar 4, 2024
@matux matux deleted the matux/examples branch March 15, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant