DRAFT 754-feat: Short track #755
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lighthouse Report:
|
|
Lighthouse Report:
|
|
Lighthouse Report:
|
ansivgit
reviewed
Jan 24, 2025
| subTitle: null, | ||
| descriptionUrl: COURSE_LINKS.SHORT_TRACK, | ||
| altTitle: COURSE_TITLES.SHORT_TRACK, | ||
| iconSrc: reactAngular, |
There was a problem hiding this comment.
Icon WO border. I remember we would like to remove all borders there, but I suppose we should remove them at the same time
ansivgit
reviewed
Jan 24, 2025
| @@ -3,13 +3,17 @@ export const communicationText = { | |||
| title: 'Communication', | |||
| subTitle: 'Discord is the main communication channel in RS School', | |||
| subTitleJs: 'RS School uses two main communication channels:', | |||
| // subTitleST: 'RS School uses two main communication channels:', | |||
ansivgit
reviewed
Jan 24, 2025
| firstParagraphFirstHalf: 'Here is link for the ', | ||
| discordParagraphTextJs: ': Join the Discord server to see the latest news and chat with students.', | ||
| discordParagraphTextJs: |
There was a problem hiding this comment.
Why are you adding a line break?
ansivgit
reviewed
Jan 24, 2025
Comment on lines
+61
to
+63
| paragraph = | ||
| path === 'shortTrack' ? 'The course program will consist of the following steps' : paragraph; | ||
|
|
There was a problem hiding this comment.
Suggested change
| paragraph = | |
| path === 'shortTrack' ? 'The course program will consist of the following steps' : paragraph; | |
| paragraph = (path === 'shortTrack') | |
| ? 'The course program will consist of the following steps' | |
| : paragraph; |
There was a problem hiding this comment.
If the linter left it as correct, should we fix it manually?
|
Lighthouse Report:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (select all that apply)
Description
Related Tickets & Documents
Screenshots, Recordings
Please replace this line with any relevant images for UI changes.
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?