Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm to wasmd #285

Merged
merged 1 commit into from
Dec 22, 2023
Merged

wasm to wasmd #285

merged 1 commit into from
Dec 22, 2023

Conversation

gupadhyaya
Copy link
Member

@gupadhyaya gupadhyaya commented Dec 22, 2023

Overview

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

Summary by CodeRabbit

  • Chores

    • Updated file paths for configuration files to improve system organization and consistency.
  • Refactor

    • Configuration and initialization scripts have been modified to reflect the new file path standards.
  • Documentation

    • Release notes have been updated to guide users through the altered configuration paths.

@gupadhyaya gupadhyaya requested a review from jcstein December 22, 2023 12:24
Copy link
Contributor

coderabbitai bot commented Dec 22, 2023

Walkthrough

The update involves a directory change for the CosmWasm configuration files, moving from ~/.wasm/ to ~/.wasmd/. This affects the location where the priv_validator_key.json and genesis.json files are stored and accessed, which are critical for node initialization and blockchain operations.

Changes

File Path Change Summary
~/.wasm/config/priv_validator_key.json Moved to ~/.wasmd/config/priv_validator_key.json
~/.wasm/config/genesis.json Moved to ~/.wasmd/config/genesis.json
jq -r '.address' ~/.wasm/config/priv_validator_key.json Path updated to ~/.wasmd/config/...
jq -r '.pub_key' ~/.wasm/config/priv_validator_key.json Path updated to ~/.wasmd/config/...

🐇✨
In the realm of code, paths intertwine,
From .wasm to .wasmd, the files align.
With a hop and a skip, the change is made,
New paths are set, in config they'll stay. 🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
    • @coderabbitai render interesting statistics about this repository as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

github-actions bot commented Dec 22, 2023

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2023-12-22 16:17 UTC

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 642cabf and 3dd8085.
Files selected for processing (1)
  • scripts/cosmwasm/init.sh (1 hunks)
Additional comments: 1
scripts/cosmwasm/init.sh (1)
  • 54-56: The script correctly updates the paths to the priv_validator_key.json file to reflect the new .wasmd directory. Ensure that the ADDRESS and PUB_KEY variables are being correctly populated with the new paths and that the jq command is functioning as expected with the updated file location.

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, LGTM

@jcstein jcstein merged commit c2e86dc into main Dec 22, 2023
2 checks passed
@jcstein jcstein deleted the fix_wasm branch December 22, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants