Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable grpc in celestia-appd #73

Merged
merged 1 commit into from
Nov 10, 2023
Merged

enable grpc in celestia-appd #73

merged 1 commit into from
Nov 10, 2023

Conversation

gupadhyaya
Copy link
Member

@gupadhyaya gupadhyaya commented Nov 10, 2023

Fixes

'blob.Submit': runtime error: invalid memory address or nil pointer dereference
github.com/filecoin-project/go-jsonrpc.doCall.func1
	/go/pkg/mod/github.com/filecoin-project/[email protected]/handler.go:276
runtime.gopanic
	/usr/local/go/src/runtime/panic.go:914
runtime.panicmem
	/usr/local/go/src/runtime/panic.go:261
runtime.sigpanic
	/usr/local/go/src/runtime/signal_unix.go:861
github.com/celestiaorg/celestia-node/state.(*CoreAccessor).getMinGasPrice
	/src/state/core_access.go:555
github.com/celestiaorg/celestia-node/state.(*CoreAccessor).SubmitPayForBlob
	/src/state/core_access.go:219
github.com/celestiaorg/celestia-node/blob.(*Service).Submit
	/src/blob/service.go:80
reflect.Value.call
	/usr/local/go/src/reflect/value.go:596
reflect.Value.Call
	/usr/local/go/src/reflect/value.go:380
github.com/filecoin-project/go-jsonrpc/auth.PermissionedProxy.func1
	/go/pkg/mod/github.com/filecoin-project/[email protected]/auth/auth.go:62
github.com/celestiaorg/celestia-node/nodebuilder/blob.(*API).Submit
	/src/nodebuilder/blob/blob.go:42
reflect.Value.call
	/usr/local/go/src/reflect/value.go:596
reflect.Value.Call
	/usr/local/go/src/reflect/value.go:380
github.com/filecoin-project/go-jsonrpc.doCall
	/go/pkg/mod/github.com/filecoin-project/[email protected]/handler.go:280
github.com/filecoin-project/go-jsonrpc.(*handler).handle
	/go/pkg/mod/github.com/filecoin-project/[email protected]/handler.go:424
github.com/filecoin-project/go-jsonrpc.(*handler).handleReader
	/go/pkg/mod/github.com/filecoin-project/[email protected]/handler.go:268
github.com/filecoin-project/go-jsonrpc.(*RPCServer).ServeHTTP
	/go/pkg/mod/github.com/filecoin-project/[email protected]/server.go:104
github.com/filecoin-project/go-jsonrpc/auth.(*Handler).ServeHTTP
	/go/pkg/mod/github.com/filecoin-project/[email protected]/auth/handler.go:47
net/http.serverHandler.ServeHTTP
	/usr/local/go/src/net/http/server.go:2938
net/http.(*conn).serve
	/usr/local/go/src/net/http/server.go:2009

as reported in https://app.warp.dev/block/cOOmG972fN4YynJPhkxm1e by @jcstein

Copy link

coderabbitai bot commented Nov 10, 2023

Walkthrough

The changes made in the entrypoint.sh script primarily revolve around the modification of the celestia-appd start command and the removal of certain commented-out lines. The --grpc.enable flag has been added to the celestia-appd start command, enhancing its functionality. Additionally, the commented-out lines related to --core.ip and --core.rpc.port in the celestia bridge start command have been removed, simplifying the script.

Changes

File Change Summary
entrypoint.sh Added the --grpc.enable flag to the celestia-appd start command. Removed commented-out lines related to --core.ip and --core.rpc.port in the celestia bridge start command.

Poem

🐇 As the leaves fall, code changes small, 🍂

In the script, we find delight, under the November light. 💻🌙

Celebrating this day in history, with code, not mystery. 🎉📜

Embracing change, in the coding range. 🔄🌐


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.
  • @coderabbitai resolve to resolve all the CodeRabbit review comments.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 24d8843 and 7e2aa02.
Files selected for processing (1)
  • entrypoint.sh (2 hunks)
Additional comments: 2
entrypoint.sh (2)
  • 57-61: The --grpc.enable flag is added to enable gRPC in the celestia-appd application. Ensure that the application supports this flag and that it is compatible with the current version of the application.

  • 78-82: The commented-out lines related to --core.ip and --core.rpc.port have been removed. Ensure that these parameters are not required elsewhere in the codebase or in the application's configuration.

@gupadhyaya gupadhyaya merged commit dd90c11 into main Nov 10, 2023
7 checks passed
@gupadhyaya gupadhyaya deleted the enable_grpc branch November 10, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants