-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable grpc in celestia-appd #73
Conversation
WalkthroughThe changes made in the Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- entrypoint.sh (2 hunks)
Additional comments: 2
entrypoint.sh (2)
57-61: The
--grpc.enable
flag is added to enable gRPC in thecelestia-appd
application. Ensure that the application supports this flag and that it is compatible with the current version of the application.78-82: The commented-out lines related to
--core.ip
and--core.rpc.port
have been removed. Ensure that these parameters are not required elsewhere in the codebase or in the application's configuration.
Fixes
as reported in https://app.warp.dev/block/cOOmG972fN4YynJPhkxm1e by @jcstein