Merge pull request #1651 from rommapp/hotfix-gallery-ejs-perf

[HOTFIX] Calculate gl support once on load
rommapp · Feb 23, 2025 · f32c55c · f32c55c
2 parents 3d8342f + 602ea8b
commit f32c55c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/backend/endpoints/responses/collection.py b/backend/endpoints/responses/collection.py
@@ -18,7 +18,7 @@ class BaseCollectionSchema(BaseModel):
 
 class CollectionSchema(BaseCollectionSchema):
     id: int
-    url_cover: str
+    url_cover: str | None
     rom_ids: set[int]
     rom_count: int
     user_id: int

diff --git a/frontend/src/__generated__/models/CollectionSchema.ts b/frontend/src/__generated__/models/CollectionSchema.ts
diff --git a/frontend/src/services/api/collection.ts b/frontend/src/services/api/collection.ts
@@ -4,7 +4,7 @@ import type { Collection, VirtualCollection } from "@/stores/collections";
 
 export type UpdatedCollection = Collection & {
   artwork?: File;
-  url_cover?: string;
+  url_cover?: string | null;
 };
 
 export const collectionApi = api;

diff --git a/frontend/src/utils/index.ts b/frontend/src/utils/index.ts
@@ -419,6 +419,10 @@ export function areThreadsRequiredForEJSCore(core: string): boolean {
   return ["ppsspp"].includes(core);
 }
 
+const canvas = document.createElement("canvas");
+const gl =
+  canvas.getContext("webgl") || canvas.getContext("experimental-webgl");
+
 /**
  * Check if EJS emulation is supported for a given platform.
  *
@@ -430,10 +434,6 @@ export function isEJSEmulationSupported(
   platformSlug: string,
   heartbeat: Heartbeat,
 ) {
-  const canvas = document.createElement("canvas");
-  const gl =
-    canvas.getContext("webgl") || canvas.getContext("experimental-webgl");
-
   return (
     !heartbeat.EMULATION.DISABLE_EMULATOR_JS &&
     getSupportedEJSCores(platformSlug).length > 0 &&