New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow user to unmatch rom #1138

Merged

gantoine merged 12 commits into rommapp:master from SaraVieira:feat/unmatch-rom

Aug 30, 2024

Contributor

SaraVieira commented Aug 30, 2024 •

edited

Loading

Adds a new button on the edit modal that allows the user to unmatch a rom if that rom has a rom.igdb_id || rom.moby_id || rom.sgdb_id. When that button is clicked the rom basically reverts to it's default state

Not sure if this is the best way to go about it, would love some opinions

Modal

closes #1103

SaraVieira added 3 commits

August 30, 2024 11:21


          feat - Allow user to unmatch rom

86aae89


          add steamgrid

dd61afd


          Merge branch 'master' of github.com:rommapp/romm into feat/unmatch-rom

e70e2a7

gantoine requested changes

View reviewed changes

Member

gantoine left a comment

Approach looks good 👍🏼 Can you add a screenshot of what it looks like in the modal?

Make sure you have trunk installed: npm install -D @trunkio/launcher, it'll automatically run as post-commit and pre-push hook

backend/endpoints/rom.py Outdated Show resolved Hide resolved

backend/endpoints/rom.py Outdated Show resolved Hide resolved

frontend/src/components/common/Game/Dialog/EditRom.vue Outdated Show resolved Hide resolved

frontend/src/components/common/Game/Dialog/EditRom.vue Outdated Show resolved Hide resolved

SaraVieira and others added 5 commits

August 30, 2024 19:11


          Merge branch 'master' of github.com:rommapp/romm into feat/unmatch-rom

72f1930


          Apply suggestions from code review

6de94aa

Co-authored-by: Georges-Antoine Assi <[email protected]>


          Merge branch 'feat/unmatch-rom' of github.com:SaraVieira/romm into fe…

fcc6772

…at/unmatch-rom


          update edit modal

c63f62a


          run trunk

fd996e3

gantoine changed the title ~~feat - Allow user to unmatch rom~~ Allow user to unmatch rom

gantoine added 3 commits

August 30, 2024 14:46


          small refactor in component


          fix trunk issues

a7aba73


          small tweaks to ui

f3f6b6e

Member

gantoine commented Aug 30, 2024

@SaraVieira I pushed a couple small changes, can you take a look at the typescript failures. You can run ts in the frontend folder with npm run typecheck.


          fix ts

885aeab

Contributor Author

SaraVieira commented Aug 30, 2024

It has been done and issues fixed :D

gantoine approved these changes

View reviewed changes

Member

gantoine left a comment

awesome, gonna squeeze this in just before the release!

gantoine merged commit 72fc6d8 into rommapp:master

4 checks passed

spiceratops referenced this pull request in spiceratops/k8s-gitops


          feat(container): update image rommapp/romm to v3.5.0 (#938)

a469f82

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [rommapp/romm](https://redirect.github.com/rommapp/romm) | minor |
`3.4.0` -> `3.5.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>rommapp/romm (rommapp/romm)</summary>

###
[`v3.5.0`](https://redirect.github.com/rommapp/romm/releases/tag/3.5.0)

[Compare
Source](https://redirect.github.com/rommapp/romm/compare/3.4.0...3.5.0)

#### What's Changed

- misc: Improve typing for feed schemas by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1064](https://redirect.github.com/rommapp/romm/pull/1064)
- \[ROMM-1063] Add Amiga CD32 to emulatorjs game list by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1065](https://redirect.github.com/rommapp/romm/pull/1065)
- fix: fab overlay fixed by
[@&#8203;zurdi15](https://redirect.github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/1073](https://redirect.github.com/rommapp/romm/pull/1073)
- fix: Readable setup text on white theme by
[@&#8203;zurdi15](https://redirect.github.com/zurdi15) in
[https://github.com/rommapp/romm/pull/1072](https://redirect.github.com/rommapp/romm/pull/1072)
- fix: Allow access to Tinfoil feed when download auth is disabled by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1078](https://redirect.github.com/rommapp/romm/pull/1078)
- fix: Set Gunicorn option forwarded-allow-ips by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1077](https://redirect.github.com/rommapp/romm/pull/1077)
- Improve speed of fetching siblings for roms by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1076](https://redirect.github.com/rommapp/romm/pull/1076)
- Ruffle flash emulator by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1049](https://redirect.github.com/rommapp/romm/pull/1049)
- Calculate and store hashes for rom files by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1005](https://redirect.github.com/rommapp/romm/pull/1005)
- Hotfix scans when running HASH_SCAN by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1081](https://redirect.github.com/rommapp/romm/pull/1081)
- Fix playing emulatorjs + better platform icon loading by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1086](https://redirect.github.com/rommapp/romm/pull/1086)
- Fix home icon size on safari/ios by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1088](https://redirect.github.com/rommapp/romm/pull/1088)
- misc: Upgrade Python to v3.12 and Alpine to v3.20 by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1092](https://redirect.github.com/rommapp/romm/pull/1092)
- feat: Use X-Accel-Redirect to improve file download speed by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1084](https://redirect.github.com/rommapp/romm/pull/1084)
- misc: Pin Node version to v20 by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1095](https://redirect.github.com/rommapp/romm/pull/1095)
- Add icon to gallery header for current platform by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1093](https://redirect.github.com/rommapp/romm/pull/1093)
- Upload progress bars by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1096](https://redirect.github.com/rommapp/romm/pull/1096)
- Skip compressed files if theyre invalid by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1097](https://redirect.github.com/rommapp/romm/pull/1097)
- Bump emulatorjs to 4.1.1 by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1100](https://redirect.github.com/rommapp/romm/pull/1100)
- feat: Use nginx mod_zip to generate multi-file zip downloads by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1102](https://redirect.github.com/rommapp/romm/pull/1102)
- misc: Use single SQLAlchemy engine and session maker by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1105](https://redirect.github.com/rommapp/romm/pull/1105)
- Switch funding to open collective by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1108](https://redirect.github.com/rommapp/romm/pull/1108)
- Replace illegal fs chars in filenames by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1109](https://redirect.github.com/rommapp/romm/pull/1109)
- Upload dialog hotfixed + clear button by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1118](https://redirect.github.com/rommapp/romm/pull/1118)
- Fix detecting if platform is flash games by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1120](https://redirect.github.com/rommapp/romm/pull/1120)
- feat(UX) - Allow links to open in a new tab by
[@&#8203;SaraVieira](https://redirect.github.com/SaraVieira) in
[https://github.com/rommapp/romm/pull/1116](https://redirect.github.com/rommapp/romm/pull/1116)
- fix(icons) - match icon names to platform names by
[@&#8203;SaraVieira](https://redirect.github.com/SaraVieira) in
[https://github.com/rommapp/romm/pull/1122](https://redirect.github.com/rommapp/romm/pull/1122)
- Disable auth on rom content get endpoint when env variable is present
by [@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1125](https://redirect.github.com/rommapp/romm/pull/1125)
- Add support for formatting vuejs with trunk by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1124](https://redirect.github.com/rommapp/romm/pull/1124)
- Add known bios files from retropie project by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1126](https://redirect.github.com/rommapp/romm/pull/1126)
- Add titledb field to tinfoil response by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1127](https://redirect.github.com/rommapp/romm/pull/1127)
- Better performance for large collections by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1128](https://redirect.github.com/rommapp/romm/pull/1128)
- \[ROMM-1113] Add file path in rom edit window by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1129](https://redirect.github.com/rommapp/romm/pull/1129)
- misc: Tag Docker image with major version only by
[@&#8203;adamantike](https://redirect.github.com/adamantike) in
[https://github.com/rommapp/romm/pull/1131](https://redirect.github.com/rommapp/romm/pull/1131)
- build(deps): bump axios from 1.6.8 to 1.7.4 in /frontend by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/rommapp/romm/pull/1132](https://redirect.github.com/rommapp/romm/pull/1132)
- Bump axios to 1.7.4 by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1134](https://redirect.github.com/rommapp/romm/pull/1134)
- \[ROMM-1107] Add env variable to disable in-browser emulation by
[@&#8203;gantoine](https://redirect.github.com/gantoine) in
[https://github.com/rommapp/romm/pull/1133](https://redirect.github.com/rommapp/romm/pull/1133)
- Default both fast forward and rewind to enabled by
[@&#8203;SaraVieira](https://redirect.github.com/SaraVieira) in
[https://github.com/rommapp/romm/pull/1136](https://redirect.github.com/rommapp/romm/pull/1136)
- Allow user to unmatch rom by
[@&#8203;SaraVieira](https://redirect.github.com/SaraVieira) in
[https://github.com/rommapp/romm/pull/1138](https://redirect.github.com/rommapp/romm/pull/1138)

#### New Contributors

- [@&#8203;SaraVieira](https://redirect.github.com/SaraVieira) made
their first contribution in
[https://github.com/rommapp/romm/pull/1116](https://redirect.github.com/rommapp/romm/pull/1116)

**Full Changelog**:
rommapp/romm@3.4.0...3.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://redirect.github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvY29udGFpbmVyIiwidHlwZS9taW5vciJdfQ==-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet