Add git top-level path when adding cscope #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't go to function definition because it's absolute path. So add top-level path of git when loading cscope.out. It assumes that cscope.out is in root of git repository.
ronakg
requested changes
Sep 17, 2021
Comment on lines
+61
to
+62
| let root_path = trim(system("git rev-parse --show-toplevel")) | ||
| execute "cs add " . db . " " . root_path |
There was a problem hiding this comment.
We do not want to do this as not all projects use git. cs add already adds the directory of the database file as the relative path.
If you really need this, this needs to be exposed as an option that's turned off by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, just made a small change to quickr-cscope.vim.
Pick this if you think it is needed.
I was using it to traverse the linux sources,
but it was difficult to go to function definitions when I was in subdirectories (like drivers/net/....)
Because the file path of function definition is relative, I was not able to open it in subdirectories.
So converted it to absolute path using the git root repository.
(Maybe there's better way because there will be a repository that does not use git)