Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bcrypt rather than crypt in simple_server example #697

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Oct 7, 2024

crypt was removed from Python 3.13. bcrypt isn't ideal, but it has acceptable password hashing, is simple to use, and is already an optional dependency of asyncssh.

`crypt` was removed from Python 3.13.  `bcrypt` isn't ideal, but it has
acceptable password hashing, is simple to use, and is already an
optional dependency of asyncssh.
Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (fab96ac) to head (32a7d72).
Report is 77 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #697      +/-   ##
===========================================
- Coverage    99.85%   99.82%   -0.04%     
===========================================
  Files           95      101       +6     
  Lines        27784    29559    +1775     
  Branches      2908     3117     +209     
===========================================
+ Hits         27743    29506    +1763     
- Misses          38       47       +9     
- Partials         3        6       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronf ronf merged commit 416db0e into ronf:develop Oct 13, 2024
15 of 16 checks passed
@ronf
Copy link
Owner

ronf commented Oct 13, 2024

Thanks for this, Colin!

As you said, bcrypt isn't ideal here but it's probably simpler than most other alternatives. This was meant to be a working example which included basic password validation, but I don't really expect someone to use this example in production code.

@cjwatson cjwatson deleted the example-simple-server-bcrypt branch October 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants