Refactored tests and prepare for tests with records #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Released an experimental package: bun add @ronin/cli@corny-ron-1099-1-experimental-128This package will be removed after the pull request has been merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
leo
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Just a small nitpick: We currently call many-to-many relationships "one-to-many", to keep the list of available kinds of relationships simple.
- many-to-one (
kind: 'one') (children reference their parents, e.g. members reference teams) - one-to-many (
kind: 'many') (parents reference their children, e.g. accounts reference followers)
leo
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the CLI tests only handle migrations with empty tables, which is not adequate for ensuring a robust migration process. I have refactored the tests to follow a coherent structure, enhancing both clarity and maintainability. In this PR, I have added code to the tests to ensure that no rows are accidentally inserted.