Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional worker for the BuiltWith API #163

Merged
merged 7 commits into from
Aug 25, 2024
Merged

Add an optional worker for the BuiltWith API #163

merged 7 commits into from
Aug 25, 2024

Conversation

moozzi
Copy link
Member

@moozzi moozzi commented Aug 19, 2024 •
edited
Loading

Closing #113

postmodern and others added 4 commits July 27, 2024 14:44
@postmodern
Version bump to 0.2.0.
ffbffc2
@nirebu @postmodern
Add a SecurityTrails API worker (ronin-rb#152)
2e279fc 
This worker will accept a domain as input and, given a valid API key,
will return a list of subdomain hosts by querying the Security Trails API.

---------

Co-authored-by: Postmodern <[email protected]>
@moozzi @postmodern
Fix att_reader description for SecurityTrails
8a26436
@postmodern
Allow Worker classes to omit defining outputs values (closes roni…
d6a4822 
…n-rb#158).

* Some workers will need to accept values, process/save them, but not
  yield any Values themselves (ex: `web/wordlist` and `web/screenshot`).
@moozzi moozzi self-assigned this Aug 19, 2024
postmodern
postmodern requested changes Aug 19, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only noticed a few stylistic things.

lib/ronin/recon/builtin/api/built_with.rb Show resolved Hide resolved
lib/ronin/recon/builtin/api/built_with.rb Show resolved Hide resolved
lib/ronin/recon/builtin/api/built_with.rb Show resolved Hide resolved
@postmodern postmodern added feature New Feature builtin Builtin Workers labels Aug 19, 2024
@postmodern postmodern added this to the 0.2.0 milestone Aug 19, 2024
@postmodern postmodern force-pushed the 0.2.0 branch 2 times, most recently from 032be97 to 9e8f021 Compare August 19, 2024 23:01
@moozzi moozzi force-pushed the add_built_with_api_worker branch from 33332ca to dbcfacd Compare August 20, 2024 16:51
postmodern
postmodern requested changes Aug 22, 2024
View reviewed changes
Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also document the environment variables used.

lib/ronin/recon/builtin/api/built_with.rb Show resolved Hide resolved
lib/ronin/recon/builtin/api/built_with.rb Show resolved Hide resolved
@moozzi moozzi force-pushed the add_built_with_api_worker branch from dbcfacd to 481dff0 Compare August 23, 2024 05:55
@postmodern postmodern merged commit 770ae49 into ronin-rb:0.2.0 Aug 25, 2024
4 checks passed
@postmodern postmodern mentioned this pull request Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@postmodern postmodern postmodern requested changes

Assignees

@moozzi moozzi

Labels
builtin Builtin Workers feature New Feature
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@moozzi @postmodern @nirebu