Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be able to see order summary at any time #389

Open
ahdinosaur opened this issue Jan 8, 2018 · 6 comments · May be fixed by #403
Open

should be able to see order summary at any time #389

ahdinosaur opened this issue Jan 8, 2018 · 6 comments · May be fixed by #403

Comments

@ahdinosaur
Copy link
Member

especially admins are keen to see what the order summary would look like if sent to suppliers

@gregorykan gregorykan changed the title should be able to see summary at any time should be able to see order summary at any time Jan 11, 2018
@michael-smith-nz
Copy link
Member

Looks like the only change will need to use orderIntents instead of orderPlans as the data source. My understanding is that they are the same data shape

@michael-smith-nz michael-smith-nz self-assigned this Jan 11, 2018
@michael-smith-nz michael-smith-nz linked a pull request Jan 11, 2018 that will close this issue
@iainkirkpatrick
Copy link
Member

butting in here for a quick thought - i'm not sure my head is fully on this / understanding the purpose, but AFAIK it won't just be a case of switching out orderPlans for orderIntents - there is always only one OrderPlan created for each unique combination of an agent, product and order, whereas there may be many Intents from an agent per product per order. I.e. I can cast intents at all the price points on bananas in an order, but only one of those is the 'true' price point at any given time (depending on the intents of the rest of the group).

There is logic (read. getters) to figure out the 'true' price point on the client, used in the product list view to show the correct price and quantity... my bet would be to use those getters in this kind of pre-emptive OrderSummary view

sorry if this has already been covered and i'm just behind 😅

@iainkirkpatrick
Copy link
Member

@NotThatSmith you are off this ticket now right? can i take it over?

@danalexilewis
Copy link

@iainkirkparick yes Michael has shifted all hit work to the “tech between us” work for now. So take it over :)

@iainkirkpatrick iainkirkpatrick self-assigned this Jan 19, 2018
@iainkirkpatrick
Copy link
Member

@agentlewis in light of sprint planning this morning, is this still relevant?

@danalexilewis
Copy link

Yes but second milestone work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants