WIP: Anywhere Order Summary #403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on this. |
iainkirkpatrick
force-pushed
the
feature/anywhere-order-summary
branch
from
ffc737a to
77f5e80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR order summary uses
orderPlansto show what users have ordered.orderPlansare only created when an order is closed. We useorderIntentsuntil then.orderIntentsandorderPlanshave the same data shape, so this PR should hopefully be as easy as switchingorderPlans withorderIntents` when an order is still open.Currently, this doesn't work for open orders. I suspect the problem to be in the
shouldQueryAgainchecks. There's also some renaming of functions that need to happen as most util functions now accept bothorderPlansandorderIntentsfixes #389