Add --ignore-bind (bind is already fast without bypassing)
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
disable-bind
branch
from
cfda770 to
568e202
Compare
AkihiroSuda
changed the title
--disable-bind--disable-bind (bind is already fast without bypassing)
|
nerdctl will support this via |
This was referenced Apr 5, 2024
AkihiroSuda
changed the title
--disable-bind (bind is already fast without bypassing)--ignore-bind (bind is already fast without bypassing)
AkihiroSuda
force-pushed
the
disable-bind
branch
from
568e202 to
2ea4089
Compare
|
Renamed the flag from |
naoki9911
requested changes
Apr 8, 2024
Workaround for issue 65. This flag disables the acceleration for `bind` syscalls, as the current hook is not robust enough for `bind` with complicated setup. Anyway, the performance of `bind` is not really problematic so far in the plain Rootless Containers. So we can just keep enabling bypass4netns for `connect` and relevant syscalls, and call it for a day. See the logs of RootlessKit CI: https://github.com/rootless-containers/rootlesskit/actions/runs/8558692577/job/23453781376 - Benchmark: TCP Ports (network driver=slirp4netns, port driver=builtin): 34.8 Gbps, 34.7 Gbps - Benchmark: TCP Ports (network driver=pasta, port driver=implicit): 39.3 Gbps, 39.2 Gbps - Benchmark: UDP Ports (network driver=slirp4netns, port driver=builtin): 25.1 Gbps, 17.2 Gbps - Benchmark: UDP Ports (network driver=pasta, port driver=implicit): 37.9 Gbps, 13.2 Gbps Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
disable-bind
branch
from
2ea4089 to
1a83efa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for:
dial tcp 127.0.0.1:2379: connect: connection refused#65This flag disables the acceleration for
bindsyscalls, as the current hook is not robust enough forbindwith complicated setup.Anyway, the performance of
bindis not really problematic so far in the plain Rootless Containers. So we can just keep enabling bypass4netns forconnectand relevant syscalls, and call it for a day.See the logs of RootlessKit CI:
https://github.com/rootless-containers/rootlesskit/actions/runs/8558692577/job/23453781376