Add support to Rails 7.1 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cprodhomme
reviewed
Sep 14, 2023
active_storage_base64.gemspec
Outdated
| @@ -15,7 +15,7 @@ Gem::Specification.new do |s| | |||
| s.required_ruby_version = '>= 2.7.0' | |||
|
|
|||
| # Dependencies | |||
| s.add_dependency 'rails', '>= 7.0' | |||
| s.add_dependency 'rails', '>= 7.1' | |||
There was a problem hiding this comment.
could you accept the new Rails version 7.1.0.beta1 please ? :)
There was a problem hiding this comment.
@cprodhomme done, version 3.0.0 released. Let me know if it works for you. Thanks
santib
force-pushed
the
fix-rails-head
branch
2 times, most recently
from
c04a79a
to
205f5bc
Compare
santib
force-pushed
the
fix-rails-head
branch
from
205f5bc
to
a4ccbfd
Compare
andresg4
approved these changes
Sep 19, 2023
enzofab91
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated Gemfile for Rails 7.1 support
The Gemfile has been updated to ensure compatibility with Rails 7.1, keeping the project up-to-date with the latest Rails version.
New test added for blank base64 data
A new test has been added to the user_base64_spec to ensure that blank base64 data is properly handled by the system.
Bug fix for assigning pictures with nil or empty string
A bug related to handling picture assignments via the setter method has been fixed. The issue occurred when the input was either nil or an empty string, and it now correctly handles these cases.