Handle responses with empty users

R/osm_get_user_details.R

@@ -64,7 +64,10 @@ osm_get_user_details <- function(user_id, format = c("R", "xml", "json")) {
   format <- match.arg(format)
 
   if (length(user_id) == 1) {
-    out <- osm_details_user(user_id = user_id, format = format)
+    out <- try(osm_details_user(user_id = user_id, format = format))
+    if (inherits(out, "try-error")) { # ! HTTP 404 Not Found. Different from osm_details_users()
+      out <- empty_user()
+    }
   } else {
     out <- osm_details_users(user_ids = user_id, format = format)
   }

R/xml_to_R.R

@@ -362,6 +362,10 @@ empty_gpx <- function() {
 user_details_xml2DF <- function(xml) {
   users <- xml2::xml_children(xml)
 
+  if (length(users) == 0) {
+    return(empty_user())
+  }
+
   user_attrs <- do.call(rbind, xml2::xml_attrs(users))
   description <- xml2::xml_text(xml2::xml_child(users, "description"))
   img <- xml2::xml_attr(xml2::xml_child(users, "img"), "href")
@@ -406,6 +410,18 @@ user_details_xml2DF <- function(xml) {
 }
 
 
+empty_user <- function() {
+  out <- data.frame(
+    id = character(), display_name = character(), account_created = as.POSIXct(Sys.time())[-1],
+    description = character(), img = character(), contributor_terms = logical(), roles = character(),
+    changesets_count = integer(), traces_count = integer(), blocks_received.count = integer(),
+    blocks_received.active = integer(), blocks_issued.count = integer(), blocks_issued.active = integer()
+  )
+
+  return(out)
+}
+
+
 logged_user_details_xml2list <- function(xml) {
   user <- xml2::xml_child(xml)
 

tests/testthat/test-user_data.R

@@ -29,6 +29,23 @@ test_that("osm_details_user works", {
 
   # Check that time is extracted, otherwise it's 00:00:00 in local time
   lapply(usr, function(x) expect_false(all(strftime(as.POSIXct(x$account_created), format = "%M:%S") == "00:00")))
+
+
+  ## Empty results
+
+  with_mock_dir("mock_details_user_empty", {
+    empty_usr <- osm_get_user_details(user_id = 2)
+  })
+
+  expect_s3_class(empty_usr, "data.frame")
+  expect_named(empty_usr, column_users)
+  expect_identical(nrow(empty_usr), 0L)
+
+  mapply(
+    function(x, cl) expect_true(inherits(x, cl)),
+    x = empty_usr,
+    cl = class_columns[names(empty_usr)]
+  )
 })
 
 
@@ -50,6 +67,23 @@ test_that("osm_details_users works", {
 
   # Check that time is extracted, otherwise it's 00:00:00 in local time
   lapply(usrs, function(x) expect_false(all(strftime(as.POSIXct(x$account_created), format = "%M:%S") == "00:00")))
+
+
+  ## Empty results
+
+  with_mock_dir("mock_details_users_empty", {
+    empty_usrs <- osm_get_user_details(user_id = 2:3)
+  })
+
+  expect_s3_class(empty_usrs, "data.frame")
+  expect_named(empty_usrs, column_users)
+  expect_identical(nrow(empty_usrs), 0L)
+
+  mapply(
+    function(x, cl) expect_true(inherits(x, cl)),
+    x = empty_usrs,
+    cl = class_columns[names(empty_usrs)]
+  )
 })