“One-shot”/”Trigger” interfaces #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejalaa12
reviewed
Jul 4, 2022
| 1. extension of `hardware_interface/component_parser.cpp` to understand `one_shot` and `async` arguments on (command) interfaces | ||
| 1. extension of `hardware_interface/handle.hpp` to add this attribute into command interface handle (read/write handle) | ||
| 1. extension of `hardware_interface/handle.hpp` with getters on the interface to automatically reset value to "NaN" when interface is read | ||
| 1. propose extension of hardware interfaces to use "handle" and do not access directly to the values as it is currently done. |
There was a problem hiding this comment.
Do you mean that hardware interface would use Handle instead of double pointer?
Do you also propose to make the State/Command Interface use the handle as well?
There was a problem hiding this comment.
No, they are now “Handles” that support only double types. There are few options how to support other types, which we will do in general in the future.
| # Purpose and Use | ||
| The proposed functionality has two purposes: | ||
| - adding additional information in the hardware if and when a command has changed; and | ||
| - signaling to a controller that hardware interface has read and used a variable (async commands). |
There was a problem hiding this comment.
By resetting the values. The explained concepts enables that.
ejalaa12
approved these changes
Apr 30, 2024
| <param name="initial_position">2.78</param> | ||
| </joint> | ||
| <gpio name="flange_analog_IOs"> | ||
| <command_interface name="analog_output1" data_type="double" sync="true"/> |
There was a problem hiding this comment.
didn't you mean "async" here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves ros-controls/ros2_control#600
QUESTION: Should we actually make all the commands to be one-shot per default?