Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for github private repos #900

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AndyZe
Copy link

@AndyZe AndyZe commented Jan 19, 2025

@AndyZe
Copy link
Author

AndyZe commented Jan 23, 2025

Pinging for review. I think this is a small, straight forward change that will save people hours of research.

Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a weak user of Github Action and reviewed from that perspective, can't verify the legitimacy.

doc/index.rst Show resolved Hide resolved
doc/index.rst Outdated Show resolved Hide resolved
Copy link
Member

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating @AndyZe.

@mathias-luedtke Care to review?

@AndyZe
Copy link
Author

AndyZe commented Feb 2, 2025

Ping

Copy link
Member

@mathias-luedtke mathias-luedtke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not enable access to private repositories (like the Gitlab version), but clones selected repositories into the current repositories (which might lead to nested packages).

These shortcomings must be stated with a warning!
Or (preferred) we implement support for SSH secrets, like we do for Gitlab.

@mathias-luedtke
Copy link
Member

#902 adds support for a single deploy key.
#815 does something similar (but is it not supported yet).

For accessing Github (from a GHA), it might be simple to use a PAT anyway.

@mathias-luedtke
Copy link
Member

@AndyZe: #902 has feature parity with the gitlab implemantation.

For multiple deploy keys, webfactory/ssh-agent could be used as well:
https://github.com/mathias-luedtke/sshtest/blob/main/.github/workflows/main.yml#L40, but it seems to have an issue during the cleanup (webfactory/ssh-agent#184).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants