-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for github private repos #900
base: master
Are you sure you want to change the base?
Conversation
Pinging for review. I think this is a small, straight forward change that will save people hours of research. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a weak user of Github Action and reviewed from that perspective, can't verify the legitimacy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating @AndyZe.
@mathias-luedtke Care to review?
Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not enable access to private repositories (like the Gitlab version), but clones selected repositories into the current repositories (which might lead to nested packages).
These shortcomings must be stated with a warning!
Or (preferred) we implement support for SSH secrets, like we do for Gitlab.
@AndyZe: #902 has feature parity with the gitlab implemantation. For multiple deploy keys, |
I got the idea from here: https://stackoverflow.com/a/72883304/3499467