Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compressed_image_transport: image decompression as a stand-alone function. #51

Open
wants to merge 11 commits into
base: indigo-devel
Choose a base branch
from

Conversation

airballking
Copy link

This relates to #49.

Basically a refactoring: It exposes image decompression as a stand-alone function in a separate lib. Additionally, it refactors the compressed subscriber to use that function.

@dgossow Could you please review this pull request?

@airballking
Copy link
Author

I just saw that the Travis build for Kinetic failed because I used a C++11 feature for generating meaningful error messages. I will fix that.

@airballking
Copy link
Author

airballking commented Mar 12, 2020

Just pushed a commit that should fix the compilation issues for Kinetic, i.e. no longer using C++11 feature std::to_string. Let's see what Travis says.

@airballking
Copy link
Author

@dgossow The build now passes on Travis.

I also checked the refactoring on my laptop by bringing up a usb_cam node as a source, starting a rqt_image_view node as a sink, and then played with various compression settings while viewing the compressed image. Worked fine.

@dgossow Could you please have a look at this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants