Obstacle layer name is obstacle_layer #641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ault used by move_base costmaps
LeroyR
force-pushed
the
fix_default_clear_costmap_layer
branch
from
948ee40 to
af7e3ca
Compare
|
Thanks for finding this bug. I haven't tested it myself yet, but I'd rather fix this by changing the backwards-compatible name in costmaps than changing the recovery behavior, since other people may rely on the default configuration of the recovery behavior. What do you think? |
|
I don't know how many people use either of the current configuration. Could be that other people interact with the obstacle_layer with different plugins or other custom applications. How about adding both layers to the clearing? |
|
I proposed an alternative here: #1005 |
|
#1005 supersedes this, closing this request. insert rant about fragmentation of forks after 3 year merge window 😄 |
|
The rant would be well deserved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed clearable_layers_default to obstacle_layer as this is the name used by move_base costmaps
https://github.com/ros-planning/navigation/blob/kinetic-devel/costmap_2d/src/costmap_2d_ros.cpp#L216