Skip to content

Commit

Permalink
Declare dependency on membership and repositories for each release te…
Browse files Browse the repository at this point in the history
…am module. (#34)

Terraform can normally create accurate dependency models between
resources without any explicit declarations but due to the way that we
separate team membership and repositor within the release team module
and overall organization membership and repository configuration it is
possible for this project to error during terraform apply when
attempting to add a repository to a team before that repository has been
created.

This dependency is rather heavyweight since it means that none of the
modules can start until all of the members and repositories are created
but I don't know of a way to "reach out" from within the module to
declare the dependency without passing these resources as variables into
it.

depends_on *must* be a static list so we can't use any kind of
sophisticated expression to generate a list of dependencies on only the
members and repositories of this release team.
However, since new repositories and members are created somewhat
infrequently and the entire terraform apply takes a lot less time
compared to the state refresh during planning this over-declaration will
likely not impact overall performance in a significant way.
  • Loading branch information
nuclearsandwich authored May 13, 2022
1 parent 9b79c54 commit 4f2864d
Show file tree
Hide file tree
Showing 103 changed files with 103 additions and 0 deletions.
1 change: 1 addition & 0 deletions acceleration_wg.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ module "acceleration_wg_team" {
team_name = "acceleration_wg"
members = local.acceleration_wg_team
repositories = local.acceleration_wg_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ackermann_msgs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "ackermann_msgs_team" {
team_name = "ackermann_msgs"
members = local.ackermann_msgs_team
repositories = local.ackermann_msgs_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions apex.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ module "apex_team" {
team_name = "apex"
members = local.apex_team
repositories = local.apex_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions apriltag.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "apriltag_team" {
team_name = "apriltag"
members = local.apriltag_team
repositories = local.apriltag_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions astuff.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "astuff_team" {
team_name = "astuff"
members = local.astuff_team
repositories = local.astuff_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions async_web_server_cpp.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "async_web_server_cpp_team" {
team_name = "async_web_server_cpp"
members = local.async_web_server_cpp_team
repositories = local.async_web_server_cpp_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions autoware.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ module "autoware_team" {
team_name = "autoware"
members = local.autoware_team
repositories = local.autoware_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions aws.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "aws_team" {
team_name = "aws"
members = local.aws_team
repositories = local.aws_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions behaviortree.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "behaviortree_team" {
team_name = "behaviortree"
members = local.behaviortree_team
repositories = local.behaviortree_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions bno055.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "bno055_team" {
team_name = "bno055"
members = local.bno055_team
repositories = local.bno055_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions connextdds.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "connextdds_team" {
team_name = "connextdds"
members = local.connextdds_team
repositories = local.connextdds_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions control.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ module "control_team" {
team_name = "control"
members = local.control_team
repositories = local.control_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions control_box_rst.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "control_box_rst_team" {
team_name = "control_box_rst"
members = local.control_box_rst_team
repositories = local.control_box_rst_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions cyberbotics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ module "cyberbotics_team" {
team_name = "cyberbotics"
members = local.cyberbotics_team
repositories = local.cyberbotics_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions cyclonedds.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "cyclonedds_team" {
team_name = "cyclonedds"
members = local.cyclonedds_team
repositories = local.cyclonedds_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions diagnostics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "diagnostics_team" {
team_name = "diagnostics"
members = local.diagnostics_team
repositories = local.diagnostics_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions dolly.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "dolly_team" {
team_name = "dolly"
members = local.dolly_team
repositories = local.dolly_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions fastcdr.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ module "fastcdr_team" {
team_name = "fastcdr"
members = local.fastcdr_team
repositories = local.fastcdr_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions fmi.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "fmi_team" {
team_name = "fmi"
members = local.fmi_team
repositories = local.fmi_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions fogros2.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ module "fogros2_team" {
team_name = "fogros2"
members = local.fogros2_team
repositories = local.fogros2_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions four_wheel_steering_msgs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "four_wheel_steering_msgs_team" {
team_name = "four_wheel_steering_msgs"
members = local.four_wheel_steering_msgs_team
repositories = local.four_wheel_steering_msgs_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions foxglove_msgs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "foxglove_msgs_team" {
team_name = "foxglove_msgs"
members = local.foxglove_msgs_team
repositories = local.foxglove_msgs_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions gazebo.tf
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ module "gazebo_team" {
team_name = "gazebo"
members = local.gazebo_team
repositories = local.gazebo_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions geographic_info.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "geographic_info_team" {
team_name = "geographic_info"
members = local.geographic_info_team
repositories = local.geographic_info_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions grbl.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "grbl_team" {
team_name = "grbl"
members = local.grbl_team
repositories = local.grbl_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions gscam.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "gscam_team" {
team_name = "gscam"
members = local.gscam_team
repositories = local.gscam_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions gurumdds.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "gurumdds_team" {
team_name = "gurumdds"
members = local.gurumdds_team
repositories = local.gurumdds_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions iceoryx.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "iceoryx_team" {
team_name = "iceoryx"
members = local.iceoryx_team
repositories = local.iceoryx_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ifm3d.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "ifm3d_team" {
team_name = "ifm3d"
members = local.ifm3d_team
repositories = local.ifm3d_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ijnek.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ module "ijnek_team" {
team_name = "ijnek"
members = local.ijnek_team
repositories = local.ijnek_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions imu_tools.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "imu_tools_team" {
team_name = "imu_tools"
members = local.imu_tools_team
repositories = local.imu_tools_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions irobot_education.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ module "irobot_education_team" {
team_name = "irobot_education"
members = local.irobot_education_team
repositories = local.irobot_education_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions lanelet2.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "lanelet2_team" {
team_name = "lanelet2"
members = local.lanelet2_team
repositories = local.lanelet2_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions lgsvl.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "lgsvl_team" {
team_name = "lgsvl"
members = local.lgsvl_team
repositories = local.lgsvl_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions libg2o.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "libg2o_team" {
team_name = "libg2o"
members = local.libg2o_team
repositories = local.libg2o_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions locator_ros_bridge.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "locator_ros_bridge_team" {
team_name = "locator_ros_bridge"
members = local.locator_ros_bridge_team
repositories = local.locator_ros_bridge_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions mavlink.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "mavlink_team" {
team_name = "mavlink"
members = local.mavlink_team
repositories = local.mavlink_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions micro_ros_diagnostics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "micro_ros_diagnostics_team" {
team_name = "micro_ros_diagnostics"
members = local.micro_ros_diagnostics_team
repositories = local.micro_ros_diagnostics_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions micro_ros_msgs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "micro_ros_msgs_team" {
team_name = "micro_ros_msgs"
members = local.micro_ros_msgs_team
repositories = local.micro_ros_msgs_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions microstrain.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "microstrain_team" {
team_name = "microstrain"
members = local.microstrain_team
repositories = local.microstrain_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions moveit.tf
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ module "moveit_team" {
team_name = "moveit"
members = local.moveit_team
repositories = local.moveit_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions mrpt2.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ module "mrpt2_team" {
team_name = "mrpt2"
members = local.mrpt2_team
repositories = local.mrpt2_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions mrt_cmake_modules.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "mrt_cmake_modules_team" {
team_name = "mrt_cmake_modules"
members = local.mrt_cmake_modules_team
repositories = local.mrt_cmake_modules_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions navigation.tf
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ module "navigation_team" {
team_name = "navigation"
members = local.navigation_team
repositories = local.navigation_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions neobotix.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "neobotix_team" {
team_name = "neobotix"
members = local.neobotix_team
repositories = local.neobotix_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions nmea.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "nmea_team" {
team_name = "nmea"
members = local.nmea_team
repositories = local.nmea_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions nobleo.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "nobleo_team" {
team_name = "nobleo"
members = local.nobleo_team
repositories = local.nobleo_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions nodl.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "nodl_team" {
team_name = "nodl"
members = local.nodl_team
repositories = local.nodl_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ntpd_driver.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "ntpd_driver_team" {
team_name = "ntpd_driver"
members = local.ntpd_driver_team
repositories = local.ntpd_driver_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions object_analytics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "object_analytics_team" {
team_name = "object_analytics"
members = local.object_analytics_team
repositories = local.object_analytics_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions octomap.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ module "octomap_team" {
team_name = "octomap"
members = local.octomap_team
repositories = local.octomap_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ompl.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "ompl_team" {
team_name = "ompl"
members = local.ompl_team
repositories = local.ompl_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ouster_drivers.tf
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ module "ouster_drivers_team" {
team_name = "ouster_drivers"
members = local.ouster_drivers_team
repositories = local.ouster_drivers_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions ouxt.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ module "ouxt_team" {
team_name = "ouxt"
members = local.ouxt_team
repositories = local.ouxt_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions pal_robotics.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ module "pal_robotics_team" {
team_name = "pal_robotics"
members = local.pal_robotics_team
repositories = local.pal_robotics_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions perception.tf
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ module "perception_team" {
team_name = "perception"
members = local.perception_team
repositories = local.perception_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions phidgets.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "phidgets_team" {
team_name = "phidgets"
members = local.phidgets_team
repositories = local.phidgets_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions picknik.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ module "picknik_team" {
team_name = "picknik"
members = local.picknik_team
repositories = local.picknik_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions plotjuggler.tf
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ module "plotjuggler_team" {
team_name = "plotjuggler"
members = local.plotjuggler_team
repositories = local.plotjuggler_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions rclc.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "rclc_team" {
team_name = "rclc"
members = local.rclc_team
repositories = local.rclc_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions rcpputils.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,6 @@ module "rcpputils_team" {
team_name = "rcpputils"
members = local.rcpputils_team
repositories = local.rcpputils_repositories
depends_on = [github_membership.members, github_repository.repositories]
}

1 change: 1 addition & 0 deletions realsense.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "realsense_team" {
team_name = "realsense"
members = local.realsense_team
repositories = local.realsense_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions rmf.tf
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,5 @@ module "rmf_team" {
team_name = "rmf"
members = local.rmf_team
repositories = local.rmf_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions roboception.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,5 @@ module "roboception_team" {
team_name = "roboception"
members = local.roboception_team
repositories = local.roboception_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions robot_localization.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ module "robot_localization_team" {
team_name = "robot_localization"
members = local.robot_localization_team
repositories = local.robot_localization_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
1 change: 1 addition & 0 deletions robotis.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ module "robotis_team" {
team_name = "robotis"
members = local.robotis_team
repositories = local.robotis_repositories
depends_on = [github_membership.members, github_repository.repositories]
}
Loading

0 comments on commit 4f2864d

Please sign in to comment.