Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Accuracy with RCUTILS #672

Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from

Conversation

CursedRock17
Copy link
Contributor

This pull request is meant to pair with this RCUTILS PR which will close #68, that way the feature is used immediately. I kept the durationToSec function as to prevent an API/ABI breakage. The tests pass locally when the RCUTILS fix is applied, but they'll fail until the PR over there is resolved, as there will be too much error without the exact rounding seen originally in this repository.

Signed-off-by: CursedRock17 <[email protected]>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz
Copy link
Contributor

sloretz commented May 10, 2024

It looks like this PR is blocked on an issue in rmw_fastrtps ros2/rcutils#460 (comment) Assigning @ahcorde to look into it post-Jazzy 🧇

Signed-off-by: CursedRock17 <[email protected]>
@CursedRock17
Copy link
Contributor Author

As per this comment ros2/rcutils#460 (comment) it seems the general consensus was that we we're changing to a method opposed to a macro for increased accuracy, so I've just prepped this PR for when the other one is complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reuse logic from Time::durationToSec method
3 participants