Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rmw_enclave_options_xxx APIs instead. #491

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

fujitatomoya
Copy link
Contributor

Copy link
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yadunund can you take a look?

@fujitatomoya
Copy link
Contributor Author

@Yadunund i would like to request some help here.

since ros2/rmw#393 is merged, i tried to test this PR with that rmw change. but many tests are failing (for example, test_rmw_implementation and so on) and i am not sure how to proceed the test... could you give me some info how i test rmw_zenoh at this moment? (localtest only for rmw_zenoh are passing though.)

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for updating the implementation here.

Unfortunately we still cannot run a ci job from ci.ros2.org with rmw_zenoh just yet.

For now i'd recommend importing packages using the ros2.repos file from ros2/ros2#1649, switching the rmw_zenoh branch to fujitatomoya/rmw_options_enclave and running

colcon test --packages-select rcl rcl_lifecycle rcl_action test_comunication test_rclcpp test_quality_or_service rclcpp rclcpp_components rclcpp_lifecycle rclcpp_action rclpy  --event-handlers console_direct+

There should be no test failures from the above.

If running colcon test on the entire ROS 2 workspace, we can expect to see failures reported in #493.

@Yadunund
Copy link
Member

Yadunund commented Mar 5, 2025

I ran CI locally and no new regressions so i'll go ahead and merge this.

Note: We won't be backporting this to jazzy/humble.

@Yadunund Yadunund merged commit 13dacc6 into rolling Mar 5, 2025
4 of 5 checks passed
@Yadunund Yadunund deleted the fujitatomoya/rmw_options_enclave branch March 5, 2025 08:28
@fujitatomoya
Copy link
Contributor Author

@Yadunund thanks, i will do this for next time if rmw_zenoh needs to be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants