Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

fixed message generation for local build #62

Open
wants to merge 1 commit into
base: kinetic
Choose a base branch
from

Conversation

LeroyR
Copy link

@LeroyR LeroyR commented Nov 24, 2017

this fixes failing message generation in non catkin build folder.

Without this fix message_generation fails to generate message files if the given package folder is named differently than the pkg as the package of single files is guessed from the path which fails on non catkin workspaces which results in empty rosjava_message/pkg jars.

This fix forces all files in the given package parameter into the given pkg_name if only one argument is given for package-path and pkg-name.

- args4j dep for cmdline parsing
@jubeira
Copy link

jubeira commented Nov 24, 2017

Hi @LeroyR, thanks for submitting this.
Could you provide more details about the use-case that was failing for you? What would be the correct way to test this?

@LeroyR
Copy link
Author

LeroyR commented Nov 25, 2017

Clone a message project into a random folder name (our jenkins) and build with cmake: mkdir build, cd build, cmake .., make
The package of each message definition is guessed from the path resulting in no code generation and empty jars

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants