Improve node launching for rosrun

[gautamjain]

Made the changes that @jubeira mentioned in #33.

I used theinstallDist task instead of installApp.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[gautamjain]

I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[jubeira]

Thanks @gautamjain!
I've gave it a quick try and it didn't work for me; I still see the scripts directory after installing. Maybe something changed along the Gradle version since the time I posted that suggested fix?
Have you tried this on your side with a sample package?

[gautamjain]

Yes, it worked when I tried it. The scripts directory in the subproject's build directory was no longer there.

This is how I tested. Let me know if I missed something:

• Cloned the modified rosjava_build_tools into my catkin workspace
• ran catkin_make and sourced devel/setup.bash
• confirmed that which catkin_create_rosjava_project and which catkin_create_rosjava_pkg was pointing to the scripts under devel/bin
• ran the scripts and generated new a package and a project
• Tested by running ./gradlew installDist. When I commented out the new tasks, the scripts directory would reappear.

Using the default gradle wrapper (4.10.2).

[gautamjain]

I also removed the << operator which is deprecated (and not available in Gradle 5.0).

[gautamjain]

Hey @jubeira,

If you have any ideas on why it might not be working on your end, let me know. I can try to replicate on my machine.

[jubeira]

Thanks @gautamjain; I've been a bit packed lately but I have this on my radar. I'll give it another shot and let you know!

[jubeira]

Re-tested; this works.

The only detail is that this change does not affect rosjava modules (e.g. pubsub tutorial) don't have this task set, so rosrun still can't be used for tutorials inside rosjava_core.

[jubeira]

Thanks @gautamjain!