Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic platforms #314

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Remove problematic platforms #314

merged 1 commit into from
Feb 11, 2025

Conversation

pabzm
Copy link
Member

@pabzm pabzm commented Feb 3, 2025

The removed platforms repeatedly caused building errors on the OS level (nothing we can fix).

Since they are pretty niche, too, I'm proposing to remove them.

The removed platforms repeatedly caused building errors, and are pretty
niche, too.
@pabzm pabzm marked this pull request as ready for review February 3, 2025 14:45
@pabzm pabzm requested a review from thomascube February 3, 2025 14:45
@pabzm
Copy link
Member Author

pabzm commented Feb 3, 2025

@williamdes FYI, since you were the one that had suggested to include those architectures two years ago. If you have an opinion on this, please let us know!

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the ping

This is a bit sad for s390x but that's probably okay for the number of users that use it

@pabzm
Copy link
Member Author

pabzm commented Feb 11, 2025

@thomascube I'm merging this without your approval because currently all nightly builds are broken and people start to notice.

If we really want to include these platforms we can always find a way to make the builds reliable and re-introduce them.

@pabzm pabzm merged commit 2e7f0d5 into master Feb 11, 2025
3 checks passed
@pabzm pabzm deleted the reduced-platforms branch February 11, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants