Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Make HTTP daemons use public_html/ as document root #321

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pabzm
Copy link
Member

@pabzm pabzm commented Feb 13, 2025

To protect files outside of the document root against unauthorized
access.
This is possible and recommended since a while, and will be required for
Roundcubemail v1.7.

This fixes the nightly builds.

Closes #319 and #320

@pabzm pabzm requested a review from thomascube February 13, 2025 09:23
@pabzm pabzm mentioned this pull request Feb 13, 2025
@pabzm pabzm changed the title Make HTTP daemons use public_html/ as document root Draft: Make HTTP daemons use public_html/ as document root Feb 13, 2025
@pabzm pabzm removed the request for review from thomascube February 13, 2025 09:28
@pabzm pabzm marked this pull request as draft February 13, 2025 09:29
@pabzm
Copy link
Member Author

pabzm commented Feb 13, 2025

I realised that I have to write docker-entrypoint.sh in a way that works for all variants, which now is the case.

Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it not be changed at build time ?

@pabzm
Copy link
Member Author

pabzm commented Feb 13, 2025

Can it not be changed at build time ?

I was just wondering about that myself :)

To protect files outside of the document root against unauthorized
access.
This is possible and recommended since a while, and will be required for
Roundcubemail v1.7.
This file is new since the move require the use of public_html
@pabzm
Copy link
Member Author

pabzm commented Feb 13, 2025

Now it's better and ready for review.

@pabzm pabzm marked this pull request as ready for review February 13, 2025 10:26
Copy link
Contributor

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, less runtime changes = better rootless support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Docker CI working?
2 participants