Fix virtuser_file plugin email2user() function not accounting for backward slashes in username #9668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the fix! Could you maybe add a short comment above the changed line to give future developers an idea, why this is necessary? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses login issues when using aliases, if the resolved username includes a '@' character.
In the /etc/postfix/virtual file, usernames including a '@' character are saved with a leading '' character.
For example:
[email protected] becomes rocky.balboa**@**company.com
The function right above (user2email()) is accounting for this issue, it just seems it was forgotten for email2user().
I discovered this because I am using Roundcube with Webmin/Virtualmin.
Starting recent versions, Virtualmin includes the '@' character in internal usernames. In previous versions it was replaced by a '%' character, thus there was no need for a leading ''.