This repository has been archived by the owner on Jan 5, 2025. It is now read-only.
merge upstream #279
Merged
merge upstream #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like these localhost references were being stripped out anyway, so this isn't a bugfix but just a small cleanup.
This PR adds a new Rules of React reference section that covers the major rules that help developers author idiomatic React apps. --------- Co-authored-by: Sathya Gunasekaran <[email protected]>
Small change to match the sidebar order.
Co-authored-by: Sebastian Silbermann <[email protected]> Co-authored-by: Allison Strandberg <[email protected]>
This example contains a list of person objects, but only the first 3 have id properties. This appears to be a mistake; in the next use of the list all 5 person objects have this property, but it is not changed as part of an instructive exercise. This change makes the final two with objects consistent with the remainder of the list.
`an text area` -> `a text area` `an discussion` -> `a discussion`
…eactjs#6728) Signed-off-by: Faridul Islam <[email protected]>
Noticed this randomly and couldn't unsee it, so here's a quick PR to fix.
…s#6743) * change isOpen variable in TopNav component to isMenuOpen to differentiate from isOpen props in Search component change setIsOpen to setIsMenuOpen in TopNav component * move initialization of ShowSearch state to top-level of TopNav component organize hook initializations in TopNav component: useState, useRef, useRouter * remove initialYScroll prop from DocSearchModal component to fix search functionality on ios devices
* Add docs for onCaughtError and onUncaughtError * Updates from feedback
Note that this component is not actually expandable and the ref got likely unused when that was removed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.