Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install systemd package early #1630

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Install systemd package early #1630

merged 1 commit into from
Feb 12, 2025

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Feb 11, 2025

Since version 42 Fedora comes with pre-installed
systemd-standalone-sysusers package which conflicts with systemd
package which prevents dnf5daemon-server from being installed.

See errors during the container build here: https://artifacts.dev.testing-farm.io/8d2a79aa-95f5-41b4-b09c-42e6f65a5ede/

@kontura
Copy link
Contributor

kontura commented Feb 11, 2025

I might be mistaken but doesn't the error happen a bit earlier in the dnf5 -y install $COPR_RPMS;?

@jrohel jrohel self-assigned this Feb 11, 2025
@jrohel
Copy link
Contributor

jrohel commented Feb 11, 2025

I reproduced the issue locally. And this PR (adding --allowerasing to dnf5 -y builddep ...) fixed the problem.

There is another approach. To explicitly install systemd as soon as possible (right after the upgrade). But what's better...

# enable dnf5
RUN set -x && \
    dnf -y --refresh upgrade; \
    dnf -y install systemd --allowerasing; \
    dnf -y install dnf5 dnf5-plugins; \
    ...

@kontura
Copy link
Contributor

kontura commented Feb 12, 2025

I think it can fail in either of the builddep step or the dnf5 -y install $COPR_RPMS I mentioned.
When the COPR and COPR_RPMS environment variables are set (like in the linked log) it fails there (because it can also install dnf5daemon-server package), if they are not set it fails in the builddep step.

I would probably explicitly install systemd as soon as possible to prevent these issues. It would also be good to add a comment explaining why its done.

Since version 42 Fedora comes with pre-installed
systemd-standalone-sysusers package which conflicts with systemd
package. This prevents dnf5daemon-server from being installed.

With this patch, systemd-standalone-sysusers is early replaced by
systemd.
@m-blaha m-blaha force-pushed the mblaha/fix-rawhide-testing branch from 75c2417 to 2e3ef24 Compare February 12, 2025 08:19
@m-blaha
Copy link
Member Author

m-blaha commented Feb 12, 2025

Good points guys, I've changed the fix to the proposed solution.

@m-blaha m-blaha changed the title Add --allowerasing to the "dnf builddep" Install systemd package early Feb 12, 2025
@jrohel
Copy link
Contributor

jrohel commented Feb 12, 2025

Thanks.

@jrohel jrohel merged commit c61c94a into main Feb 12, 2025
5 checks passed
@jrohel jrohel deleted the mblaha/fix-rawhide-testing branch February 12, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants