system::State - check permissions and wrap exception #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not perfect as the permissions might change between this check and the actual system state writing.
The same exception can come from `utils::fs::File`.
This was referenced Dec 13, 2023
|
LGTM, but I see a lot of failing tests. The testing farm problem sounds new to me. |
|
It looks like an issue mentioned yesterday. DNF5 test was running with DNF command. |
Merged
via the queue into
rpm-software-management:main
with commit Dec 15, 2023
c6ca49e
5 of 9 checks passed
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1080
This is an alternative to: #1081
Test: rpm-software-management/ci-dnf-stack#1428