-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix improve example16 #109
Bugfix improve example16 #109
Conversation
@rpoleski I have figured out some minor fixes in my previous commits, so I will work on it by the end of the week before you merge. Please also let me know if the version number should be updated. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 52 52
Lines 8185 8185
=======================================
Hits 6833 6833
Misses 1352 1352
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Very final and minor changes:
|
It contains all the improvements to example 16 listed in issue #93.
As a complement, the value
optimal
is now allowed in "plots" -> "best model" -> "second Y scale" -> "magnifications", in order to calculate optimal values of magnification instead of giving values that can be out of range. Ifoptimal
is provided,labels
can not be given for this axis.