Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix improve example16 #109

Merged
merged 13 commits into from
Nov 17, 2023

Conversation

rapoliveira
Copy link
Contributor

@rapoliveira rapoliveira commented Oct 27, 2023

It contains all the improvements to example 16 listed in issue #93.

As a complement, the value optimal is now allowed in "plots" -> "best model" -> "second Y scale" -> "magnifications", in order to calculate optimal values of magnification instead of giving values that can be out of range. If optimal is provided, labels can not be given for this axis.

@rapoliveira
Copy link
Contributor Author

@rpoleski I have figured out some minor fixes in my previous commits, so I will work on it by the end of the week before you merge. Please also let me know if the version number should be updated.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #109 (6ad88e5) into master (828190b) will not change coverage.
The diff coverage is n/a.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files          52       52           
  Lines        8185     8185           
=======================================
  Hits         6833     6833           
  Misses       1352     1352           
Flag Coverage Δ
unittests 83.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rpoleski
Copy link
Owner

Very final and minor changes:

  • please change version number to 0.34.0
  • Functions: _second_Y_axis_get_fluxes(), _second_Y_axis_optimal(), and _second_Y_axis_warnings() - please add a docstring just saying what they do (1 sentence is enough)
  • in these functions, please change returns with multiple values: return A, B -> return (A, B)

@rpoleski rpoleski merged commit 106f682 into rpoleski:master Nov 17, 2023
1 check passed
rapoliveira added a commit to rapoliveira/MulensModel that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants