Improve mutation processing performance #1652

Open

eoghanmurray wants to merge 25 commits intorrweb-io:masterfrom eoghanmurray:pushAddOrder

+1,289-561

Commits on Feb 11, 2025

Iterate over the added nodes in 'one pass' so that we don't need to backtrack; pushAdd requires that each new node has a parentId and a nextId
eoghanmurray
committed
Test changes, rearrangement of mutations
eoghanmurray
committed
Add some ids as I'm interested in tracing these nodes through pushAdd (console)
eoghanmurray
committed
Do away with the second pass as we can handle shadow DOM in the first pass
eoghanmurray
committed
This is needed on latest ubuntu
eoghanmurray
committed
Performance oriented refactor focusing on scenario where a large number of child nodes share the same parent
eoghanmurray
committed
Satisfy typescript which could be smarter here ... we can guarantee that if a possibly null node is in e.g. this.addedSet, then it is indeed not null. Similarly if this.addedSet.size is non zero,…
eoghanmurray
committed
Utilize lastChild to avoid possibly crawling through hundreds of nodes
eoghanmurray
committed
We've already got nextSibling here so can skip a step and avoid the confusing initialization to IGNORED_NODE
eoghanmurray
committed
Test rearrangements in the adds array due to new algorithm; should be equivalent but might have implications in terms of how replay should iterate over them
eoghanmurray
committed
We were calling inDom in all cases, so don't do the other ancestor checks if it goes bad early
eoghanmurray
committed
Don't think we're explicitly looking at the slimdom stuff in relation to mutation processing
eoghanmurray
committed
Add changeset
eoghanmurray
committed
Don't think main subfolder was ever used as an output target; this was preventing benchmark test from running
eoghanmurray
committed
Placate eslint (while(true) is a Pythonism rather than do..while) - could also use checkLoops: allExceptWhileTrue after eslint upgrade
eoghanmurray
committed
Forgot to add the mutation.html file - also add doctype
eoghanmurray
committed
Simplify the parentId check, doesn't need to ever by null
eoghanmurray
committed

Commits on Feb 12, 2025

Commits on Feb 13, 2025

Satisfy eslint
eoghanmurray
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve mutation processing performance #1652

Commits on Feb 11, 2025

Iterate over the added nodes in 'one pass' so that we don't need to backtrack; pushAdd requires that each new node has a parentId and a nextId

Test changes, rearrangement of mutations

Add some ids as I'm interested in tracing these nodes through pushAdd (console)

Do away with the second pass as we can handle shadow DOM in the first pass

This is needed on latest ubuntu

Performance oriented refactor focusing on scenario where a large number of child nodes share the same parent

Satisfy typescript which could be smarter here ... we can guarantee that if a possibly null node is in e.g. this.addedSet, then it is indeed not null. Similarly if `this.addedSet.size` is non zero,…

Utilize `lastChild` to avoid possibly crawling through hundreds of nodes

We've already got `nextSibling` here so can skip a step and avoid the confusing initialization to `IGNORED_NODE`

Test rearrangements in the adds array due to new algorithm; should be equivalent but might have implications in terms of how replay should iterate over them

We were calling `inDom` in all cases, so don't do the other ancestor checks if it goes bad early

Don't think we're explicitly looking at the slimdom stuff in relation to mutation processing

Add changeset

Don't think `main` subfolder was ever used as an output target; this was preventing benchmark test from running

Placate eslint (`while(true)` is a Pythonism rather than do..while) - could also use `checkLoops: allExceptWhileTrue` after eslint upgrade

Forgot to add the mutation.html file - also add doctype

Simplify the parentId check, doesn't need to ever by null

Commits on Feb 12, 2025

Move mutation tests into their own files to demonstrate an idea which could be applied across all snapshots. Also, only mutation events are relevant here (reduce burden when manually expecting test…

Apply formatting changes

Some inconsequential tests to cover blocking scenarios

Was trying to 'catch out' the mutation handling by having siblings present on mutation processing before they could be added, but couldn't (deliberately) break anything. Adding test anyway as it mi…

fixup! Move mutation tests into their own files to demonstrate an idea which could be applied across all snapshots. Also, only mutation events are relevant here (reduce burden when manually expecti…

I can't recreate a scenario for this case in testing, so add a warning and a speculative mitigation

Put each snap file in it's own folder and shorten names

Commits on Feb 13, 2025

Satisfy eslint