forked from stoically/syn-rsx
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom node implementation, add visitor API and stable unqoted text. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vldm
force-pushed
the
test-custom-nodes
branch
from
January 8, 2024 18:07
2f657bf
to
8c683c1
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 76.93% 71.26% -5.67%
==========================================
Files 12 18 +6
Lines 750 1507 +757
==========================================
+ Hits 577 1074 +497
- Misses 173 433 +260 ☔ View full report in Codecov by Sentry. |
vldm
force-pushed
the
test-custom-nodes
branch
2 times, most recently
from
January 8, 2024 18:15
252689c
to
1034d21
Compare
vldm
force-pushed
the
test-custom-nodes
branch
from
January 8, 2024 18:43
1034d21
to
24c3d64
Compare
vldm
force-pushed
the
test-custom-nodes
branch
from
January 9, 2024 17:05
0dccd7d
to
0471cfd
Compare
vldm
force-pushed
the
test-custom-nodes
branch
from
January 9, 2024 18:05
d81be52
to
8378681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #13
Closes: #5
This pr contain a lot of fixes, few of them refactor CustomNode to use ParseRecoverable and ToTokens instead of custom methods.
New crate rstml-controll-flow was added in order to show how to use CustomNode in real project.
Added visitor API and refactored html-to-string-macro to use it.
Added hack for stable to parse unquoted text correctly, this is hidden behind feature gate "rawtext-stable-hack"
Because hack is using
source_text
function, it cannot be used if template macro called from generated input.Macro matcher module allows extracting html template from macro arguments.