Refactor parsers integration #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arserFactory only parse redeem scripts (not scripsigs anymore). Return getSigInsertionIndex method to Script class. Remove ParseResult class.
… in test folder to RedeemScriptTestUtils
julia-zack
changed the base branch from
master
to
redeem-script-parsers-refactor-integration
marcos-iov
reviewed
Nov 6, 2023
src/test/java/co/rsk/bitcoinj/script/RedeemScriptParserFactoryTest.java
Outdated
Show resolved
Hide resolved
nathanieliov
reviewed
Nov 7, 2023
src/test/java/co/rsk/bitcoinj/script/RedeemScriptParserFactoryTest.java
Outdated
Show resolved
Hide resolved
marcos-iov
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove RedeemScriptParser from Script constructor. Make RedeemScriptParserFactory only parse redeem scripts (not scripsigs anymore). Return getSigInsertionIndex method to Script class. Remove ParseResult class.