Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update use of RedeemScriptParser interface to support new changes #321

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

nathanieliov
Copy link
Contributor

@nathanieliov nathanieliov commented Oct 8, 2024

Description

  • Update use of RedeemScriptParser interface to support new changes after refactoring.
  • Update test to use FlyoverRedeemScriptBuilderImpl and get rid of use of the removed FastBridgeRedeemScriptParser

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)

@nathanieliov nathanieliov requested a review from a team as a code owner October 8, 2024 15:38
@marcos-iov marcos-iov force-pushed the wip/fed-scripts-refactors-integration branch from 03159af to a143ece Compare October 10, 2024 13:27
…fter refactoring.

- Update test to use FlyoverRedeemScriptBuilderImpl and get rid of use of the removed FastBridgeRedeemScriptParser
@marcos-iov marcos-iov force-pushed the wip/fed-scripts-refactors-integration branch from a143ece to 626acf2 Compare October 18, 2024 15:58
Copy link

sonarcloud bot commented Oct 18, 2024

@marcos-iov marcos-iov merged commit 0338ed1 into master Oct 18, 2024
8 checks passed
@marcos-iov marcos-iov deleted the wip/fed-scripts-refactors-integration branch October 18, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants