Settup and add initial svp tests. #200
Conversation
jeremy-then
force-pushed
the
setup-svp-tests
branch
from
02f109c to
c5f6867
Compare
jeremy-then
force-pushed
the
setup-svp-tests
branch
from
837eddc to
eb2bea1
Compare
jeremy-then
force-pushed
the
setup-svp-tests
branch
from
eb2bea1 to
9997ec4
Compare
jeremy-then
changed the base branch from
rits-refactors-9-2024-integration
to
svp-integration
tests/00_00_04-change-federation.js
Outdated
|
|
||
| expect(proposedFederationInfo.proposedFederationCreationBlockNumber).to.be.equal(commitFederationCreationBlockNumber, 'The proposed federation creation block number should be the expected one.'); | ||
|
|
||
| const proposedFederationMembers = await getProposedFederationPublicKeys(bridge); |
There was a problem hiding this comment.
| const proposedFederationMembers = await getProposedFederationPublicKeys(bridge); | |
| const proposedFederationPublicKeys = await getProposedFederationPublicKeys(bridge); |
There was a problem hiding this comment.
I updated something similar, got confused. Now updated.
tests/00_00_04-change-federation.js
Outdated
|
|
||
| }); | ||
|
|
||
| it('should not have created svp transaction and there should not be any SVP values in storage yet', async () => { |
There was a problem hiding this comment.
| it('should not have created svp transaction and there should not be any SVP values in storage yet', async () => { | |
| it('should not have created svp fund transaction and there should not be any SVP values in storage yet', async () => { |
|
| @@ -23,7 +23,81 @@ var compareFederateKeys = (publicKeysA, publicKeysB) => { | |||
| return comparison; | |||
| }; | |||
|
|
|||
| const getActiveFederationPublicKeys = async (bridge) => { | |||
There was a problem hiding this comment.
What do you think of using powpeg-details library?
Not now, but if you think it's a good idea we can add it in a separate PR
There was a problem hiding this comment.
It only works for the active federation.
| return bytesStr; | ||
| }; | ||
|
|
||
| const getBridgeStorageValueDecodedHexString = (bridgeStorageValueEncodedAsRlp, append0xPrefix = true) => { |
There was a problem hiding this comment.
I think we implemented this in one of our libraries didn't we? Might be a good idea anyway to have maybe a specialized library that reads values from the Bridge storage
| @@ -13,7 +13,7 @@ | |||
| "license": "GPL3", | |||
| "dependencies": { | |||
| "@rsksmart/bridge-state-data-parser": "^1.2.0", | |||
| "@rsksmart/bridge-transaction-parser": "^1.1.4", | |||
| "@rsksmart/bridge-transaction-parser": "github:rsksmart/bridge-transaction-parser#fbdeb686fc438f530d3a5f01bce062fd455be01f", | |||
There was a problem hiding this comment.
Why this? Do we need a new release for bridge-transaction-parser?
There was a problem hiding this comment.
Yes. We need to update the @rsksmart/rsk-precompiled-abis dependency in the bridge-transaction-parser library. Check: rsksmart/bridge-transaction-parser@master...use-lovel-precompiled-abis-commit
| @@ -34,7 +34,7 @@ | |||
| "mocha-junit-reporter": "^2.2.1", | |||
| "pegin-address-verificator": "git+https://[email protected]/rsksmart/pegin-address-verifier#v0.4.0", | |||
| "peglib": "git+https://github.com/rsksmart/rsk-peglib#v1.4.15", | |||
| "@rsksmart/rsk-precompiled-abis": "^6.0.0-ARROWHEAD", | |||
| "@rsksmart/rsk-precompiled-abis": "github:rsksmart/precompiled-abis#841aa8f0caab0356ae510708bfb2fceae9144790", | |||
| @@ -56,7 +56,7 @@ global.Runners = { | |||
| fingerroot500: 1, | |||
| arrowhead600: 1, | |||
| arrowhead631: 1, | |||
| lovell700: -1, | |||
| lovell700: 1, | |||
There was a problem hiding this comment.
I thought we planned on staring with Lovell inactive. Then test pre and post Lovell
No description provided.