Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate nodejs transport in favor of ktor #287

Merged
merged 1 commit into from
Feb 9, 2025

Conversation

whyoleg
Copy link
Member

@whyoleg whyoleg commented Feb 9, 2025

Motivation:

Ktor 3.1 will support sockets (ktor-network) for wasmJs and Js targets, so rsocket-transport-nodejs-tcp will is deprecated and will be dropped in next release

@whyoleg whyoleg self-assigned this Feb 9, 2025
Copy link

github-actions bot commented Feb 9, 2025

Test Results

  877 files   -  1    877 suites   - 1   37m 3s ⏱️ - 2m 10s
3 849 tests  - 24  3 116 ✅  - 18    733 💤  - 6  0 ❌ ±0 
8 304 runs   - 24  6 688 ✅  - 18  1 616 💤  - 6  0 ❌ ±0 

Results for commit decc3b5. ± Comparison against base commit aeaf294.

♻️ This comment has been updated with latest results.

@whyoleg whyoleg merged commit 43cc2b7 into master Feb 9, 2025
20 checks passed
@whyoleg whyoleg deleted the deprecate-nodejs-transport branch February 9, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant