docs: Discuss BS5 with Bootswatch in ?navbar_options.
#1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In setting up rstudio/shinycoreci#283 – where we'll have test coverage for the default
page_navbar()appearance with all Bootswatch themes – I realized that we need better instructions specifically for anyone using BS5 with a Bootswatch preset.I added a new section to
?navbar_optionsthat walks through the process for getting the same navbar appearance as can be found in the Bootswatch docs for a theme. I also touched on the Sass variables we introduce.rstudio/shinycoreci#283 reveals that the changes in the default appearance are sub-optimal, but open the door for better customization that more closely follows upstream best practices – i.e. you could follow the Bootswatch or Bootstrap docs because they easily translate to
navbar_options().I've considered a few other options for improving the default experience, but it's difficult to do without adding more undesirable complexity.