Skip to content

Commit

Permalink
feat: Include path to chrome log file in failed to connect message
Browse files Browse the repository at this point in the history
When we fail to launch chrome, we print out the contents of stderr in the error message. But there are often important details hidden in the stdout logs.

This PR adds the full path to the log file with the lines printed to stdout in the error message when chrome fails to launch.
  • Loading branch information
gadenbuie authored May 2, 2024
1 parent 916ebc5 commit 469e3f4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion R/chrome.R
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,9 @@ launch_chrome_impl <- function(path, args, port) {
if (!p$is_alive()) {
stop(
"Failed to start chrome. Error: ",
paste(readLines(p$get_error_file()), collapse = "\n")
paste(readLines(p$get_error_file()), collapse = "\n"),
"\nMore details may be found in the following log file:\n",
p$get_output_file()
)
}
tryCatch(
Expand Down

0 comments on commit 469e3f4

Please sign in to comment.