-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some basic print methods #140
Conversation
I like this summarized info, but for debugging purposes, I also often find it useful to see all the public and private stuff, so that I can find what to poke at. (Those IDs emitted by the new print methods are also only useful for debugging.) Is there some way that we could make it obvious for people to figure out how to print all that other info? |
#Conflicts: # NEWS.md # man/ChromoteSession.Rd
#Conflicts: # NEWS.md
@@ -544,7 +544,7 @@ ChromoteSession <- R6Class( | |||
#' active debugging session? | |||
mark_closed = function(target_closed) { | |||
private$session_is_active <- FALSE | |||
private$target_is_active <- target_closed | |||
private$target_is_active <- !target_closed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops
Now looks like this: library(chromote)
x <- ChromoteSession$new()
x
#' <ChromoteSession> (session + target active)
#' Session ID: D6A397FF2C4E44C53D67CC7F44CDD87C
#' Target ID: 7C7D2B9E67D70B01A9664F143047205E
#' Parent PID: 22035
x$parent
#' <Chromote> (active + alive)
#' URL: http://127.0.0.1:20993
#' PID: 22035
#' Path: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
# sleep --------------
x
#' <ChromoteSession> (target active)
#' Target ID: 7C7D2B9E67D70B01A9664F143047205E
#' Parent PID: 22035
x$parent
#' <Chromote> (alive)
#' URL: http://127.0.0.1:20993
#' PID: 22035
#' Path: /Applications/Google Chrome.app/Contents/MacOS/Google Chrome |
Created on 2024-01-30 with reprex v2.0.2.9000