feat: Include path to chrome log file in failed to connect message #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we fail to launch chrome, we print out the contents of stderr in the error message. But there are often important details hidden in the stdout logs. This PR adds the full path to the log file with the lines printed to stdout in the error message when chrome fails to launch.
kevinushey
reviewed
May 2, 2024
wch
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we fail to launch chrome, we print already out the contents of stderr in the error message. But there are often important details hidden in the stdout logs.
This PR adds the full path to the log file with the lines printed to stdout in the error message when chrome fails to launch.
Fixes #151