feat: Set a user-specific crash dump directory #194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #134
Sets
--crash-dumps-dir
for each session and usestempfile()
to create a consistent path name for a given session. (Previously, stdout and stderr would be written to log files with different "hashes".)With this change, we now use the same tempdir prefix for all three session-specific files/directories:
{tempdir}/chrome-bd71710535fb-crashpad/
for crash dumps{tempdir}/chrome-bd71710535fb-stdout.log
{tempdir}/chrome-bd71710535fb-stderr.log