Misc performance improvements for nanoplots / vec_*()
functions.
#1888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve a little performance for
vec_*()
by avoiding converting to a tibble and remove some dplyr calls togroup_vars()
.This could probably be improved further, but saw these quick fixes so I added that.
Checklist
testthat
unit tests totests/testthat
for any new functionality.I wonder if this could be improved further. I used the first example of
cols_nanoplot()
Before
This PR:
![image](https://private-user-images.githubusercontent.com/52606734/370446983-625aab1e-5b6a-4769-bc7b-aca7a57bb4ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4OTYyNzYsIm5iZiI6MTczODg5NTk3NiwicGF0aCI6Ii81MjYwNjczNC8zNzA0NDY5ODMtNjI1YWFiMWUtNWI2YS00NzY5LWJjN2ItYWNhN2E1N2JiNGFlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDAyMzkzNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI4MWJiNjM3NDgwNWVhMTM2Yzc0NDAyMWE1MTVmNjk0ZjUyOWNjMmJmMGI4YzU0ZTZjMzczZDkzZjMzYWE3N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.EN21W_s9lVE4eYrN_hSTDkUbuZLeVDtf-c0Kg8wDUas)
~8% gain! Not that bad I guess?