Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: add an adhoc chart-releaser #242

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colearendt
Copy link
Contributor

@colearendt colearendt commented Jul 11, 2022

add an adhoc chart-releaser that is triggered by the /release-adhoc

This allows for releasing (in an adhoc fashion) from a branch. Unfortunately the behavior and how this will work for non-devel releases is not super well-defined. If chart-releaser adds support for filtering to only certain releases, that would be helpful to make this safer: helm/chart-releaser#196

In particular, it is most concerning if chart A moves to --devel version on the dev branch, chart B moves to a newer version on main, and then CI runs based on a /release-adhoc comment. It would also be concerning if chart A or chart B move to a newer version on a branch and then publish a "non-devel" version from the branch.

It requires being an OWNER on the repository, although it is unclear if this correlates to ADMIN privileges within the organization.

@colearendt colearendt requested a review from atheriel July 11, 2022 17:52
@colearendt colearendt marked this pull request as draft July 11, 2022 21:01
@colearendt
Copy link
Contributor Author

colearendt commented Jul 11, 2022

Moved this to a draft, because @atheriel and I decided that:

  • this has some potentially annoying / dangerous edge cases (creating a mess that will be annoying to clean up)
  • it is an attempt to solve a set of problems that could also be solved other ways... i.e.
    • A different release mechanism compared to chart-releaser (chart releaser creates some of these problems)
    • A different branching mechanism (i.e. running dev releases off of the dev branch) and merging back/forth from main to keep things up to date
    • Triggering off of tags and running tag-based releases
    • Using the main branch, but dev versions and having a more formal release process where the action is triggered manually when a release is desirable
  • Ultimately the demand for this feature is relatively short-lived and rare (i.e. once every 3-6 months). It can usually be ameliorated in other ways (i.e. by being careful on main, blocking main for new point releases while a dev release is in flight, etc.).

Much of this pain is caused by having the version in Chart.yaml and README.md, the merge conflicts that that creates, and only having a single "source of truth" to trigger releases (i.e. main) - or again causing more merge conflicts.

@colearendt colearendt changed the title add an adhoc chart-releaser DRAFT: add an adhoc chart-releaser Jul 11, 2022
… issue comment

This allows for releasing (in an adhoc fashion) from a branch. Unfortunately the behavior and how this will work for non-devel releases is not super well-defined. If chart-releaser adds support for filtering to only certain releases, that would be helpful to make this safer: helm/chart-releaser#196

In particular, it is most concerning if chart A moves to `--devel` version on the `dev` branch, chart B moves to a newer version on `main`, and then CI runs based on a `/release-adhoc` comment. It would also be concerning if chart A or chart B move to a newer version on a branch and then publish a "non-devel" version from the branch.

It requires being an `OWNER` on the repository, although it is unclear if this correlates to `ADMIN` privileges within the organization.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant